Add shared data model types for groups and multi-part payloads - #57
Merged
Conversation
1 task
Introduce foundational types for observation groups and named payloads: - GroupId and PayloadId identifier types - PayloadBuilder for constructing named payloads - Updated Observation struct: labels → group_ids, added parent_group_id, added ObservationType::Group variant - InvalidPayloadId error variant
Dig-Doug
force-pushed
the
groups-1-models
branch
from
February 21, 2026 15:28
8870640 to
b2de3f2
Compare
This was referenced Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupIdandPayloadIdidentifier typesPayloadBuilderfor constructing named payloadsObservationstruct:labels→group_ids, addparent_group_id, addObservationType::GroupInvalidPayloadIderror variantStack: PR 1/6 — shared model types (foundation for subsequent PRs)
cargo check -p observation-tools-sharedpasses. Client/server crates will break until later PRs in the stack.Test plan
cargo check -p observation-tools-sharedcompiles🤖 Generated with Claude Code